GATE CSE
First time here? Checkout the FAQ!
x
+2 votes
436 views

Consider the following C program that attempts to locate an element x in an array Y[ ] using binary search. The program is erroneous. 

 f (int Y[10] , int x) {
    int u, j, k;
    i= 0; j = 9;
    do {
        k = (i+ j) / 2;
        if( Y[k] < x) i = k;else j = k;
        } while (Y[k] != x) && (i < j)) ;
    if(Y[k] == x) printf(" x is in the array ") ;
    else printf(" x is not in the array ") ;
 }

The correction needed in the program to make it work properly is 

  1. Change line 6 to: if (Y[k] < x) i = k + 1; else j = k-1; 
  2. Change line 6 to: if (Y[k] < x) i = k - 1; else j = k +1; 
  3. Change line 6 to: if (Y[k] < x) i = k; else j = k;
  4. Change line 7 to: } while ((Y[k] == x) && (i < j)) ;
asked in Algorithms by Veteran (76.2k points)   | 436 views
Given progeam is errorneous bcz it is doing malfunction when we are serching for an element that not present in the array.

I.e. 10 20 30 40 50 60 70 80 90 100

Now search 65 it will go into infinite loop

And that problem occured due to improper index (i,j) updation.

and the correct updation is Option A which is followed by Binary Search.

2 Answers

+3 votes
Best answer

Ans should be A

if( Y[k] < x) then i = k + 1;

if given element that  we are searching is greater then searching will be continued upper half of array

otherwise j = k - 1;

lower half.

Take few case in consideration i.e.

1. all elements are same

2. increasing order with no repeatation

3. increasing order with  repeatation.

answered by Veteran (36.3k points)  
selected by
manoj could u explain a bit more

@asu ... see .. suppose our array is - 1, 2, 3, 4,  5, 6

and we want to search x=7, then check what happens here-

In the beginning , i=0, and j=5.

k= (0 + 5)/2 = 2.

A[2] <7, so  i=k=2.


now while (A[2] != x&& i <j) - true

2nd time - i=2, j=5.

k= (2+5)/2= 3

A[3] < 7, so i=k=3


while(A[3] !=x && i<j) - true

3rd time - i=3, j=5.

k= (3+5)/2= 4.

A[4] < 7, so i= k=4.


while(A[4] !=x && i<j) - true

3rd time - i=4, j=5.

k= (4+5)/2= 4.

A[4] < 7, so i= k=4.


while(A[4] !=x && i<j) - true

3rd time - i=4, j=5.

k= (4+5)/2= 4.

A[4] < 7, so i= k=4.

.

.

.

 will go into infinite loop.

So to get rid of this infinite loop if we put- i = k+1. instead of i=k then it would not fall into infinite loop.

..

.and you can put j= k-1 and even j=k is also okay. 

 

.

 

@vijay...thank u for explaniation ....but to check each option it will take much time..any suggestion for these kind of question

Sorry @asu .. I am also working on it  ... but I think .. while reading BST .or any topic... if we consider every cases and especially edge case then we can solve most of the question related to any topic .. smiley

 

0 votes
Just try to search Last element : it will go into infinite loop because of interger division.

i=k+1 will solve the problem.

lets elemets are : 10 20 30 40 50 60 70 80 90 100

now try to search 25 or 35 or 45 or 55 on above array so it will run into infinite loop.

so we need both the conditions=i=k+1 and j=k-1

P.S: This program is errorenous because of unsuccessful search.
answered by Veteran (22.4k points)  


Top Users Apr 2017
  1. akash.dinkar12

    3514 Points

  2. Divya Bharti

    2546 Points

  3. Deepthi_ts

    2040 Points

  4. rude

    1966 Points

  5. Tesla!

    1768 Points

  6. Shubham Sharma 2

    1610 Points

  7. Debashish Deka

    1588 Points

  8. Arunav Khare

    1454 Points

  9. Kapil

    1424 Points

  10. Arjun

    1420 Points

Monthly Topper: Rs. 500 gift card

22,076 questions
28,042 answers
63,233 comments
24,135 users